Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

[#5] Add Code Review trail

  • Loading branch information...
commit e46792c4f34170b0d6ecf8d13c1fd0cc6d92369d 1 parent 8f400e0
Adarsh Pandit authored September 21, 2012 croaky committed September 22, 2012
1  README.md
Source Rendered
@@ -29,6 +29,7 @@ Trails
29 29
 ------
30 30
 
31 31
 * [CSS](/thoughtbot/trail-map/blob/master/trails/css.md)
  32
+* [Code Review](/thoughtbot/trail-map/blob/master/trails/code-review.md)
32 33
 * [Git](/thoughtbot/trail-map/blob/master/trails/git.md)
33 34
 * [Grids](/thoughtbot/trail-map/blob/master/trails/grids.md)
34 35
 * [HTML](/thoughtbot/trail-map/blob/master/trails/html.md)
27  trails/code-review.md
Source Rendered
... ...
@@ -0,0 +1,27 @@
  1
+Code Review
  2
+===========
  3
+
  4
+Critical Learning
  5
+-----------------
  6
+
  7
+* Read [feature branch code reviews](http://goo.gl/jIcOv).
  8
+* Read [Best Practices of Peer Code Review](http://goo.gl/A8Boc).
  9
+
  10
+Validation
  11
+----------
  12
+
  13
+You know how to review code when you can:
  14
+
  15
+* Comment on a specific line number.
  16
+* Comment constructively and politely.
  17
+* Learn something valuable from the comments.
  18
+* Express appreciation to the author.
  19
+* Respond the request in a timely manner.
  20
+
  21
+You know how to have your code reviewed when you can:
  22
+
  23
+* Create small pull requests, which are easier to review.
  24
+* Take comments as constructive and not personal criticism.
  25
+* Learn something valuable from the comments.
  26
+* Express appreciation to the reviewer.
  27
+* Respond to comments in a timely manner.

0 notes on commit e46792c

Please sign in to comment.
Something went wrong with that request. Please try again.