Permalink
Browse files

[#5] Add Code Review trail

  • Loading branch information...
1 parent 8f400e0 commit e46792c4f34170b0d6ecf8d13c1fd0cc6d92369d Adarsh Pandit committed with croaky Sep 21, 2012
Showing with 28 additions and 0 deletions.
  1. +1 −0 README.md
  2. +27 −0 trails/code-review.md
View
1 README.md
@@ -29,6 +29,7 @@ Trails
------
* [CSS](/thoughtbot/trail-map/blob/master/trails/css.md)
+* [Code Review](/thoughtbot/trail-map/blob/master/trails/code-review.md)
* [Git](/thoughtbot/trail-map/blob/master/trails/git.md)
* [Grids](/thoughtbot/trail-map/blob/master/trails/grids.md)
* [HTML](/thoughtbot/trail-map/blob/master/trails/html.md)
View
27 trails/code-review.md
@@ -0,0 +1,27 @@
+Code Review
+===========
+
+Critical Learning
+-----------------
+
+* Read [feature branch code reviews](http://goo.gl/jIcOv).
+* Read [Best Practices of Peer Code Review](http://goo.gl/A8Boc).
+
+Validation
+----------
+
+You know how to review code when you can:
+
+* Comment on a specific line number.
+* Comment constructively and politely.
+* Learn something valuable from the comments.
+* Express appreciation to the author.
+* Respond the request in a timely manner.
+
+You know how to have your code reviewed when you can:
+
+* Create small pull requests, which are easier to review.
+* Take comments as constructive and not personal criticism.
+* Learn something valuable from the comments.
+* Express appreciation to the reviewer.
+* Respond to comments in a timely manner.

0 comments on commit e46792c

Please sign in to comment.