Create Code Review trail #5

Closed
croaky opened this Issue May 6, 2012 · 6 comments

Projects

None yet

4 participants

@croaky
Member
croaky commented May 6, 2012

No description provided.

@drapergeek
Member

Does this mean that you learn how to do code reviews or that you have your code reviewed?

@adarsh
Contributor
adarsh commented Jun 5, 2012

@drapergeek I would say both - learn the process of how to review code effectively as well as describe integration into overall workflow.

@garethrees
Contributor

Ideas for this:

  • Comment on a pull request
  • Create a pull request
  • Comment on a line number (in GitHub file browser view)
  • Run a Dojo
@garethrees
Contributor
@adarsh adarsh pushed a commit that referenced this issue Sep 23, 2012
Adarsh Pandit [#5] Add Code Review trail 3f299a9
@adarsh adarsh pushed a commit that referenced this issue Sep 23, 2012
Adarsh Pandit [#5] Add Code Review trail e46792c
@croaky
Member
croaky commented Sep 23, 2012

Merged.

@croaky croaky closed this Sep 23, 2012
@yangchenyun yangchenyun added a commit to yangchenyun/trail-map that referenced this issue Oct 22, 2012
@yangchenyun yangchenyun Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Update book links to amazon affiliate shortened links.
  Add GitHub Ruby style guide
  Add community driven Ruby style guide
  Update README.md
  Fix grammatical error.
  Fix broken contributors link
  Tighten writing in README
  Remove .gitignore
  [#5] Add Code Review trail
  Update credits
  Create RubyMotion trail

Conflicts:
	README.md
	trails/Development/ruby/ruby-basic.md
	trails/Development/unix/unix.md
86bf06d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment