Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

JavaScript guide improvements #99

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

afeld commented Jan 25, 2013

  • spelling corrections and section name clarifications
  • adding of JavaScript Garden and style guides

@adarsh adarsh commented on the diff Jan 25, 2013

trails/ruby.json
@@ -29,7 +29,7 @@
]
},
{
- "name": "Expand your knowledge.",
+ "name": "Expand your knowledge",
@adarsh

adarsh Jan 25, 2013

Contributor

For consistency, I'd like to leave this period correction out. We should make all files either end in periods or none of them.

Plus, it's incongruent with the main purpose of this pull.

I'm going to make this small change and merge.

Thanks for the PR, @afeld!

@afeld

afeld Jan 25, 2013

Contributor

I'm confused... are you agreeing that none of the other section names end with periods?

@adarsh

adarsh Jan 25, 2013

Contributor

No, I agree this change is a good one. I just feel the period cleanup should probably be done wholesale in another PR.

Maybe adding in this incremental improvement is useful, so I'll keep it.

I'm in process of writing a JSON manifest to validate these data structures - that should help in terms of consistency.

Contributor

adarsh commented Jan 25, 2013

Squashed and merged into ec6901d.

Thanks for the PR!

@adarsh adarsh closed this Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment