Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: thoughtworks/cruisecontrol.rb
base: master
...
head fork: tecnobrat/cruisecontrol.rb
compare: bug/fix_nil_log_exception
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 commit comment
  • 1 contributor
View
1  app/helpers/application_helper.rb
@@ -76,6 +76,7 @@ def display_builder_state(state)
end
def format_changeset_log(log)
+ log = "" if log.blank?
h(log.strip)
end
View
5 test/unit/application_helper_test.rb
@@ -35,6 +35,11 @@ class ApplicationHelperTest < ActionView::TestCase
end
context "#format_changeset_log" do
+ test "should render nothing if log is nil" do
+ @helper.extend(ERB::Util)
+ assert_equal "", @helper.format_changeset_log(nil)
+ end
+
test "should strip html tags" do
@helper.extend(ERB::Util)
assert_equal "&lt;hr /&gt;some changeset&lt;script&gt;alert('bad')&lt;/script&gt;",

Showing you all comments on commits in this comparison.

@SeanMarcia
Collaborator

Thanks for this fix! Foomip fixed this another way, he used

CGI.escapeHTML(log.strip)

Which removed the exception. Sorry it took so long for someone to reply. I was just recently given access to the project so you can expect more timely replies to anything.

Something went wrong with that request. Please try again.