Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture performance now records start and delta-t for each frame #158

Merged
merged 1 commit into from Mar 1, 2015

Conversation

@ccoenen
Copy link
Contributor

commented Feb 22, 2015

I was curious about the framerate and the shortest possible delay between framegrabs. I used your capture_performance-tool and altered it slightly.

It now adds two things to the previous state: start time (in ms since start of psmoveapi) and time between two iterations.

In the end it will print a summary to STDOUT.

@ccoenen ccoenen force-pushed the ccoenen:morestats branch from 622c381 to eb68c3a Feb 22, 2015

@@ -114,14 +114,20 @@ main(int argc, char *argv[])
printf("\nTesting frame grab performance\n");
FILE *fp = fopen("capture_grab.csv", "w");
assert(fp != NULL);
fprintf(fp, "frame,grab,retrieve,converted");
fprintf(fp, "frame,start,grab,retrieve,converted");

This comment has been minimized.

Copy link
@thp

thp Mar 1, 2015

Owner

Please add start and diff to the end (after all the tracking%d elements), so that existing code that parses the fields in order instead of reading the headers and assigning keys this way will still work (and also fix the ordering below accordingly.

@thp

This comment has been minimized.

Copy link
Owner

commented Mar 1, 2015

Looks good and can be merged after you reorder the newly-added CSV output fields to be at the end of a line instead of adding them somewhere in between. Thanks!

@ccoenen ccoenen force-pushed the ccoenen:morestats branch from eb68c3a to 5640ab3 Mar 1, 2015

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2015

alright, it's all appended, now.

@ccoenen ccoenen force-pushed the ccoenen:morestats branch from 5640ab3 to 197169b Mar 1, 2015

thp added a commit that referenced this pull request Mar 1, 2015

Merge pull request #158 from ccoenen/morestats
capture performance now records start and delta-t for each frame

@thp thp merged commit 54084c8 into thp:master Mar 1, 2015

@thp

This comment has been minimized.

Copy link
Owner

commented Mar 1, 2015

Merged, thanks!

@ccoenen ccoenen deleted the ccoenen:morestats branch Mar 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.