Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows install paths with spaces on MacOS #348

Merged
merged 2 commits into from Feb 21, 2018
Merged

Allows install paths with spaces on MacOS #348

merged 2 commits into from Feb 21, 2018

Conversation

TimArt
Copy link
Contributor

@TimArt TimArt commented Feb 19, 2018

I've modified the MacOS build script to allow compilation in a directory hierarchy that includes directory names with spaces in them. I did this by using "weak quoting" in bash. I also added git submodule initialization and updating so when a user goes to build for MacOS they do not first need to know about git submoduling.

I've added a comment on each line I've changed to help explain. Some of these comments are unnecessary and will probably be removed.

Thanks!

@thp
Copy link
Owner

thp commented Feb 19, 2018

Yeah, no need to add comments to each line. Remove the comments if possible. Also, maybe this is a good time to run it through the shellcheck utility (https://www.shellcheck.net, brew install shellcheck on macOS) and fix those things.

@TimArt
Copy link
Contributor Author

TimArt commented Feb 19, 2018

I removed my unnecessary comments and corrected the following lines based on shellcheck:

screen shot 2018-02-19 at 11 56 08 am

Let me know if there's anything I've done that you want modified.

@thp
Copy link
Owner

thp commented Feb 21, 2018

Cool, thank you!

@thp thp merged commit aed4e22 into thp:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants