Add importModuleFromResources (#2) #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 14, 2013 11:23
Add an importModuleFromResources, which read the code from the resources file, and didn't use the importlib so can be use with python < 3.1. This doesn't enable import of module located in QtResources from the python code, which will require a more complex implementation with hook in python capi. This solve the thp#2 enhancement request.
…can be imported from pycode with import. That s works in progress fullpath aren t managed, and bytecode py[c|o] file can t be used. The path finder should be written and not hardcoded with ":/"+module_name+".py"
…nit__.py) probably not safe yet
|
Hi, can you squash those changes, rebase them against the latest Git master revision and remove all the code that you commented out because it wasn't needed? |
|
Obsoleted by commit 5c8d9cf, which implements importing transparently using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an importModuleFromResources, which read the code from the resources
file, and didn't use the importlib so can be use with python < 3.1.
This doesn't enable import of module located in QtResources from the
python code, which will require a more complex implementation with hook
in python capi. This solve the #2 enhancement request.