Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Engine) Bump Golangci-lint to 1.19.1 #365

Closed
wants to merge 3 commits into from

Conversation

@xtda
Copy link
Member

commented Oct 7, 2019

Description

This PR bumps GolangCI-Lint from v1.18.0 to v1.19.1

Mainly because of:
image

But there is also a few other performance improvements & overall 1.13 support improvements

golangci/golangci-lint@v1.18.0...v1.19.1

Fixes #my constant inserting of newlines

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

golangci-lint run -verbose 
go clean -testcache && go test ./... -race -v

both run locally and pass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules
@xtda xtda requested review from thrasher-, gloriousCode and shazbert Oct 7, 2019
…nters being added
@codecov

This comment has been minimized.

Copy link

commented Oct 7, 2019

Codecov Report

Merging #365 into engine will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           engine     #365      +/-   ##
==========================================
+ Coverage   42.55%   42.56%   +<.01%     
==========================================
  Files         152      152              
  Lines       34028    34028              
==========================================
+ Hits        14480    14483       +3     
+ Misses      18587    18585       -2     
+ Partials      961      960       -1
Impacted Files Coverage Δ
engine/rpcserver.go 0% <ø> (ø) ⬆️
communications/slack/slack.go 64.7% <ø> (ø) ⬆️
currency/code.go 63.15% <ø> (ø) ⬆️
portfolio/portfolio.go 95.96% <ø> (ø) ⬆️
exchanges/coinut/coinut_wrapper.go 32.1% <ø> (ø) ⬆️
exchanges/lbank/lbank.go 34.11% <ø> (ø) ⬆️
config/config.go 77.96% <ø> (ø) ⬆️
exchanges/btse/btse_wrapper.go 29.41% <ø> (ø) ⬆️
exchanges/mock/recording.go 20.98% <ø> (ø) ⬆️
exchanges/anx/anx.go 61.53% <ø> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a13551...6196713. Read the comment docs.

Copy link
Collaborator

left a comment

There appears to be a panic introduced: https://ci.appveyor.com/project/thrasher-/gocryptotrader-g5pk0#L228 Can't replicate it locally however, so this might be related to Go versions < 1.13

@@ -106,21 +106,21 @@ type AdEdit struct {
MaxAmount int `json:"max_amount"`
OpeningHours []string `json:"opening_hours"`
LimitToFiatAmounts string `json:"limit_to_fiat_amounts"`
Visible bool `json:"visible,int"`
Visible bool `json:"visibleq"`

This comment has been minimized.

Copy link
@shazbert

shazbert Oct 7, 2019

Collaborator

visibleq -> visible

@xtda

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

There appears to be a panic introduced: https://ci.appveyor.com/project/thrasher-/gocryptotrader-g5pk0#L228 Can't replicate it locally however, so this might be related to Go versions < 1.13

Looks to be caused by
golang/go#29612 / golang/tools@4414aad

and as you said appveyor windows images are not yet updated to 1.13
they can be manually installed using powershell but it's a workaround that will just get removed at a later date so not sure if its even worth it

Will close off PR until 1.13 support comes to windows images on appveyor

@xtda xtda closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.