Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32-bit linux build target for Travis #389

Merged
merged 7 commits into from Dec 2, 2019

Conversation

@thrasher-
Copy link
Collaborator

thrasher- commented Nov 29, 2019

Description

Adds a 32 bit build job for Travis to ensure that our codebase works on 32 bit systems due to finding and resolving this issue:

#388

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Travis CI and local testing on a 32 bit system

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules
thrasher- added 7 commits Nov 28, 2019
Copy link
Collaborator

shazbert left a comment

utACK

Copy link
Collaborator

gloriousCode left a comment

uTACK ☁️ 👾 🖲 🚈

@thrasher- thrasher- changed the title Adds 32-bit linux build target for Travis Add 32-bit linux build target for Travis Nov 29, 2019
@xtda
xtda approved these changes Dec 1, 2019
Copy link
Member

xtda left a comment

utACK

@thrasher- thrasher- merged commit c27b865 into engine Dec 2, 2019
2 of 5 checks passed
2 of 5 checks passed
Review Action 0 issues found before hitting an error.
Details
Travis CI - Branch Build Failed
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@thrasher- thrasher- deleted the 32bit_testing branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.