Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set go.mod/go.sum file line endings to LF #391

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@thrasher-
Copy link
Collaborator

thrasher- commented Dec 3, 2019

Description

Introduces a .gitattributes file which sets go.mod/go.sum line endings to LF based off the discussion in: golang/go#31870

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules
Saves having Windows users experience pain and suffering as documented
here:

golang/go#31870
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #391 into engine will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           engine     #391      +/-   ##
==========================================
+ Coverage   41.42%   42.09%   +0.67%     
==========================================
  Files         167      167              
  Lines       38207    39900    +1693     
==========================================
+ Hits        15827    16796     +969     
- Misses      21274    21931     +657     
- Partials     1106     1173      +67
Impacted Files Coverage Δ
exchanges/coinbasepro/coinbasepro.go 34.2% <0%> (-0.55%) ⬇️
exchanges/zb/zb.go 71.42% <0%> (-0.37%) ⬇️
exchanges/btcmarkets/btcmarkets.go 58.72% <0%> (-0.2%) ⬇️
exchanges/huobi/huobi_websocket.go 0% <0%> (ø) ⬆️
engine/orders.go 0% <0%> (ø) ⬆️
logger/logger_types.go 100% <0%> (ø) ⬆️
exchanges/asset/asset.go 100% <0%> (ø) ⬆️
exchanges/okgroup/okgroup.go 11.83% <0%> (+0.27%) ⬆️
dispatch/mux.go 94.11% <0%> (+0.36%) ⬆️
currency/code.go 75.49% <0%> (+0.4%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5d75b...eedb97a. Read the comment docs.

Copy link
Collaborator

shazbert left a comment

tACK!

Copy link
Collaborator

gloriousCode left a comment

tACK. May I never have to revert go.mod changes again

@xtda
xtda approved these changes Dec 3, 2019
Copy link
Member

xtda left a comment

👍
tested approved

@thrasher- thrasher- merged commit 49b9ece into engine Dec 3, 2019
6 of 7 checks passed
6 of 7 checks passed
Review Action 0 issues found before hitting an error.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 0c5d75b...eedb97a
Details
codecov/project 42.09% (+0.67%) compared to 0c5d75b
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@thrasher- thrasher- deleted the engine_le branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.