Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanges: Remove ANX from codebase #408

Merged
merged 2 commits into from Jan 3, 2020
Merged

Exchanges: Remove ANX from codebase #408

merged 2 commits into from Jan 3, 2020

Conversation

@thrasher-
Copy link
Collaborator

thrasher- commented Jan 3, 2020

PR Description

After months of API errors, no more trading on their platform plus plus non-responsive emails sent to their support team, I believe it's time to remove ANX from the codebase.

This also bumps the GCT copyright year and updates the docs via the documentation tool

Type of change

Exchange removal

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested

  • go test ./... -race
  • golangci-lint run

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules
thrasher- added 2 commits Jan 3, 2020
@thrasher- thrasher- requested review from shazbert, gloriousCode, MadCozBadd and xtda and removed request for shazbert Jan 3, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #408 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   41.09%   40.91%   -0.18%     
==========================================
  Files         163      161       -2     
  Lines       39042    38450     -592     
==========================================
- Hits        16043    15733     -310     
+ Misses      21858    21607     -251     
+ Partials     1141     1110      -31
Impacted Files Coverage Δ
exchanges/support.go 100% <ø> (ø) ⬆️
engine/exchange.go 32.83% <ø> (+0.32%) ⬆️
config/config.go 85.1% <100%> (ø) ⬆️
exchanges/bitmex/bitmex_wrapper.go 55.33% <0%> (ø) ⬆️
exchanges/lakebtc/lakebtc_websocket.go 61.45% <0%> (+1.67%) ⬆️
ntpclient/ntpclient.go 50% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a277a...d8baafc. Read the comment docs.

@@ -10,14 +10,14 @@ vadimzhukck | https://github.com/vadimzhukck
marcofranssen | https://github.com/marcofranssen
MadCozBadd | https://github.com/MadCozBadd
cranktakular | https://github.com/cranktakular
leilaes | https://github.com/leilaes

This comment has been minimized.

Copy link
@shazbert

shazbert Jan 3, 2020

Collaborator

reinstate ?

This comment has been minimized.

Copy link
@thrasher-

thrasher- Jan 3, 2020

Author Collaborator

They deleted their account and is now pointing to a new person which I'm not sure if they're the same

This comment has been minimized.

Copy link
@thrasher-

thrasher- Jan 3, 2020

Author Collaborator

See #300 - just shows up as ghost now

| [cranktakular](https://github.com/cranktakular) | 5 |
| [leilaes](https://github.com/leilaes) | 3 |

This comment has been minimized.

Copy link
@shazbert

shazbert Jan 3, 2020

Collaborator

reinstate?

Copy link
Collaborator

gloriousCode left a comment

🕯🕯🕯🕯🕯 tACK 🕯🕯🕯🕯🕯
🕯🕯🕯🕯🕯 Came across no issues in testing and found no traces of ANX 🕯🕯🕯🕯🕯

Copy link
Collaborator

MadCozBadd left a comment

tACK!!!! target eliminated!

@xtda
xtda approved these changes Jan 3, 2020
Copy link
Member

xtda left a comment

Tested approved
👍

@thrasher- thrasher- merged commit 4e05ad4 into master Jan 3, 2020
6 of 7 checks passed
6 of 7 checks passed
Review Action Errored whilst reviewing.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 41.09%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +58.9% compared to 98a277a
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@thrasher- thrasher- deleted the anx_removal branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.