Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Logger) Rename package to log #444

Merged
merged 5 commits into from Feb 12, 2020
Merged

Conversation

@xtda
Copy link
Member

xtda commented Feb 12, 2020

PR Description

Just a quick small change that renames the logger package to "log" to stop the requirement of adding logger infront of the import that has annoyed me for awhile now :D

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested

  • go test ./... -race
  • golangci-lint run

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules
xtda added 3 commits Feb 12, 2020
@xtda xtda self-assigned this Feb 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #444 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   41.24%   40.96%   -0.29%     
==========================================
  Files         197      197              
  Lines       43128    43128              
==========================================
- Hits        17789    17666     -123     
- Misses      23934    23999      +65     
- Partials     1405     1463      +58
Impacted Files Coverage Δ
exchanges/poloniex/poloniex_websocket.go 12.21% <ø> (ø) ⬆️
exchanges/websocket/wshandler/wshandler.go 71.26% <ø> (-0.75%) ⬇️
engine/timekeeper.go 0% <ø> (ø) ⬆️
exchanges/btcmarkets/btcmarkets_wrapper.go 26.61% <ø> (ø) ⬆️
exchanges/exchange.go 97.22% <ø> (ø) ⬆️
exchanges/kraken/kraken_websocket.go 0% <ø> (ø) ⬆️
...rexprovider/openexchangerates/openexchangerates.go 55.46% <ø> (ø) ⬆️
portfolio/portfolio.go 97.59% <ø> (ø) ⬆️
exchanges/request/request.go 61.76% <ø> (ø) ⬆️
common/file/archive/zip.go 53.46% <ø> (ø) ⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946eb60...430b4a0. Read the comment docs.

@thrasher- thrasher- changed the title (Logger) rename package to log (Logger) Rename package to log Feb 12, 2020
Copy link
Collaborator

thrasher- left a comment

Only 2 minor nits, very convenient PR!

engine/engine.go Outdated Show resolved Hide resolved
log/logger_setup.go Outdated Show resolved Hide resolved
Copy link
Collaborator

thrasher- left a comment

Thanks for making those changes!

Copy link
Collaborator

gloriousCode left a comment

tACK! 🕯 RIP logger 🕯

Copy link

codelingo bot left a comment

LGTM

Copy link
Collaborator

MadCozBadd left a comment

LGTM

@thrasher- thrasher- merged commit 7fccc03 into thrasher-corp:master Feb 12, 2020
5 checks passed
5 checks passed
Review Action No issues found.
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 41.24%)
Details
codecov/project Absolute coverage decreased by -0.28% but relative coverage increased by +58.75% compared to 946eb60
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Christian-Achilli pushed a commit to Christian-Achilli/gocryptotrader that referenced this pull request Feb 15, 2020
* renamed package to log to stop side import requirement

* reverted comment changes

* reverted comment changes

* one more reverting wording back to logger

* wording changes on comments
@xtda xtda deleted the xtda:logger-no-side-import branch Feb 19, 2020
thrasher- added a commit that referenced this pull request Feb 24, 2020
* fix 440: SubmitOrder and CB-ACCESS-TIMESTAMP value

* removed gctcli executable and added it to gitignore

* removed nonce from conibasepro send payload

* fixed typo in executable name

* Bump github.com/grpc-ecosystem/grpc-gateway from 1.12.2 to 1.13.0 (#442)

Bumps [github.com/grpc-ecosystem/grpc-gateway](https://github.com/grpc-ecosystem/grpc-gateway) from 1.12.2 to 1.13.0.
- [Release notes](https://github.com/grpc-ecosystem/grpc-gateway/releases)
- [Changelog](https://github.com/grpc-ecosystem/grpc-gateway/blob/master/CHANGELOG.md)
- [Commits](grpc-ecosystem/grpc-gateway@v1.12.2...v1.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Minor general cleanup and bug fixes (#443)

* Bugfix, remove non-needed code and cleanup some code

* Run go mod tidy

* Remove non-needed test and fix tautological err

* Fix Huobi interim var reference

* (Logger) Rename package to log (#444)

* renamed package to log to stop side import requirement

* reverted comment changes

* reverted comment changes

* one more reverting wording back to logger

* wording changes on comments

* Bump github.com/gorilla/mux from 1.7.3 to 1.7.4 (#445)

Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/gorilla/mux/releases)
- [Commits](gorilla/mux@v1.7.3...v1.7.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* (QOL) Improve test setup for logger, improve test coverage for database (#447)

* Improved test setup for logger, improved test coverage for database

* removed some new lines

* add new line

* removed database config detailS

* removed lines

* code cleanup

* Bump github.com/d5/tengo/v2 from 2.0.2 to 2.0.4 (#449)

Bumps [github.com/d5/tengo/v2](https://github.com/d5/tengo) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/d5/tengo/releases)
- [Changelog](https://github.com/d5/tengo/blob/master/.goreleaser.yml)
- [Commits](d5/tengo@v2.0.2...v2.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump github.com/d5/tengo/v2 from 2.0.4 to 2.0.5 (#450)

Bumps [github.com/d5/tengo/v2](https://github.com/d5/tengo) from 2.0.4 to 2.0.5.
- [Release notes](https://github.com/d5/tengo/releases)
- [Changelog](https://github.com/d5/tengo/blob/master/.goreleaser.yml)
- [Commits](d5/tengo@v2.0.4...v2.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Adrian Gallagher <thrasher@addictionsoftware.com>
Co-authored-by: Andrew <andrew@disvelop.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.