Move doc files into resources and fix README links #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeLaGuardo
requested review from
gbuisson,
yogsototh,
msprunck,
ereteog,
frenchy64,
turbodog99,
rplevy,
agzam,
wandersoncferreira,
obarbeau,
marioaquino and
safi
as code owners
DeLaGuardo
force-pushed
the
fix-doc-links
branch
from
f5180ef
to
a27e086
Compare
msprunck
approved these changes
Nov 7, 2022
src/ctia/documentation/routes.clj
Outdated
| (assoc :body body) | ||
| (response/content-type "text/html") | ||
| (response/charset "UTF-8") | ||
| (response/update-header "Content-Length" (constantly (str body-length)))))) |
There was a problem hiding this comment.
Suggested change
| (response/update-header "Content-Length" (constantly (str body-length)))))) | |
| (response/header "Content-Length" (str body-length))))) |
There was a problem hiding this comment.
Thanks! No idea how I oversee header :) It's even stringifying the content automatically
NeelSaini
pushed a commit
that referenced
this pull request
Nov 7, 2022
> Related to advthreat/iroh#7273 Move documentation-related files into the resource folder so they wouldn't conflict with dependencies. <a name="qa">[§](#qa)</a> QA ============================ No QA is needed. <a name="release-notes">[§](#release-notes)</a> Release Notes ============================================================= ``` public: changed directory structure `/doc` moved to `/resources/ctia/doc` ``` <a name="squashed-commits">[§](#squashed-commits)</a> Squashed Commits ====================================================================== * Move doc files into resources and fix README links * Render markdown files for documentation routes * Fix after review
|
Cherry Picked on TEST in rel v1.109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move documentation-related files into the resource folder so they wouldn't conflict with dependencies.
§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits