-
Notifications
You must be signed in to change notification settings - Fork 25
Port CTIA to Trapperkeeper #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice! that looks very promising Ambrose, using this approach looks very straightforward, I think you should go on and convert all services init to see how it goes, you might run into issues with the store aspect as it allows multiple store instances for a given store type, but this is a feature that we never used and we should ditch that in the process: https://github.com/threatgrid/ctia/blob/master/src/ctia/store.clj#L32 |
Checkpoint: c9178ce ports auth and encryption services to TK. |
5112a06
to
67019d5
Compare
Related advthreat/iroh#3986 This PR encapsulates the global properties atom to help enable future refactorings, such as to Trapper Keeper's get-in-config. Also fixes miscellaneous small issues. Extracted from #924 § QA No QA is needed. § Release Notes intern: Encapsulate global properties atom § Squashed Commits
77e60c4
to
492717c
Compare
6f50995
to
ccbadfc
Compare
c5175b4
to
273777b
Compare
Related https://github.com/threatgrid/iroh/issues/3986
get-access-control
toget-in-config
)get-in-config
service that's compatible with fixtures before splitting PRsjoin
in ctia.main?shutdown-agents
when needed:services
map when neededctia-server-service
can be refactored to just provide routes to the TK built-in jetty serviceTentative order of PR's:
short-id->entity-type
properties bug§ Actual PRs
Seed routes with global services map argument
(under review) TK1.1: Seed routes with global services map argument #945use services map in bulk
(depends on TK1) TK2.1: use services map in bulk #950add service args to ctia.bundle.core
(depends on TK2) TK2.5: add service args to ctia.bundle.core #954add service args to entity.event
(depends on TK1.1) TK2.3: add service args to entity.event #952add services args to ctia.entity.feed
(depends on TK1.1) TK2.7: add services args to ctia.entity.feed #956add service arguments to auth.threatgrid
(no dependencies, under review) TK1.2: add service arguments to auth.threatgrid #948TK4.3: add services args to entity.casebook
(depends on TK1.1) TK2.6: add services args to entity.casebook #955jwt
(depends on TK1.1) TK2.2: add service args to auth.jwt #951TK2.8: add services args to observable routes
TK2.8: add services args to observable routes #957TK2.9: add services arg to properties routes
TK2.9: add services arg to properties routes #958TK2.10: add services args to version routes
TK2.10: add services args to version routes #959TK2.11: add services args to entity.feedback routes
TK2.11: add services args to entity.feedback routes #960TK2.12: add services args to entity.relationship routes
TK2.12: add services args to entity.relationship routes #961TK2.15: Add services arg to entity-crud-routes
TK2.15: Add services arg to entity-crud-routes #967TK3.1: add services args to flows.crud
TK3.1: add services args to flows.crud #969 (depends on TK2.15)TK3.2: add services args to graphql routes
TK3.2: add services args to graphql routes #970TK3.3: add service args to event hooks.event-hooks
TK3.3: add service args to hooks.event-hooks #971TK3.4: add service args to get-http-show
TK3.4: add service args to get-http-show #972TK3.5: add service args to get-access-control
TK3.5: add service args to get-access-control #975TK3.6: add service args to list-all-pages
TK3.6: add service args to list-all-pages #974TK3.7: misc
TK3.7: misc #973TK3.8: change config "before" app starts in access-control-test
TK3.8: change config "before" app starts in access-control-test #976TK3.9: add service args to ESConnState
TK3.9: add service args to ESConnState #984TK3.10: get-in-config in migration tests, better resource management
TK3.10: get-in-config in migration tests, better resource management #986TK3.11 misc TK prep for tests
TK3.11 misc TK prep for tests #988TK3.11: Hooks service
TK3.11: Hooks service #989TK3.12: GraphQL resolvers
TK3.12: GraphQL realize-fn #990Use fake TK app over global state several tests
Use fake TK app over global state several tests #994Introduce trapperkeeper and port IAuth service
Introduce trapperkeeper and port IAuth service #995Port remaining 10 services to Trapperkeeper
Port remaining 10 services to Trapperkeeper #997§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits