Port CTIA to Trapperkeeper - #924
Closed
frenchy64 wants to merge 372 commits into
Closed
Conversation
Contributor
|
Nice! that looks very promising Ambrose, using this approach looks very straightforward, I think you should go on and convert all services init to see how it goes, you might run into issues with the store aspect as it allows multiple store instances for a given store type, but this is a feature that we never used and we should ditch that in the process: https://github.com/threatgrid/ctia/blob/master/src/ctia/store.clj#L32 |
Contributor
Author
|
Checkpoint: c9178ce ports auth and encryption services to TK. |
frenchy64
force-pushed
the
iroh-3986-tk-init
branch
2 times, most recently
from
July 24, 2020 21:37
5112a06 to
67019d5
Compare
frenchy64
added a commit
that referenced
this pull request
Jul 30, 2020
Related threatgrid/iroh#3986 This PR encapsulates the global properties atom to help enable future refactorings, such as to Trapper Keeper's get-in-config. Also fixes miscellaneous small issues. Extracted from #924 § QA No QA is needed. § Release Notes intern: Encapsulate global properties atom § Squashed Commits
frenchy64
force-pushed
the
iroh-3986-tk-init
branch
4 times, most recently
from
August 14, 2020 22:22
77e60c4 to
492717c
Compare
frenchy64
force-pushed
the
iroh-3986-tk-init
branch
from
August 14, 2020 22:27
6f50995 to
ccbadfc
Compare
frenchy64
force-pushed
the
iroh-3986-tk-init
branch
from
August 14, 2020 22:38
c5175b4 to
273777b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/threatgrid/iroh/issues/3986
get-access-controltoget-in-config)get-in-configservice that's compatible with fixtures before splitting PRsjoinin ctia.main?shutdown-agentswhen needed:servicesmap when neededctia-server-servicecan be refactored to just provide routes to the TK built-in jetty serviceTentative order of PR's:
short-id->entity-typeproperties bug§ Actual PRs
Seed routes with global services map argument(under review) TK1.1: Seed routes with global services map argument #945use services map in bulk(depends on TK1) TK2.1: use services map in bulk #950add service args to ctia.bundle.core(depends on TK2) TK2.5: add service args to ctia.bundle.core #954add service args to entity.event(depends on TK1.1) TK2.3: add service args to entity.event #952add services args to ctia.entity.feed(depends on TK1.1) TK2.7: add services args to ctia.entity.feed #956add service arguments to auth.threatgrid(no dependencies, under review) TK1.2: add service arguments to auth.threatgrid #948TK4.3: add services args to entity.casebook(depends on TK1.1) TK2.6: add services args to entity.casebook #955jwt(depends on TK1.1) TK2.2: add service args to auth.jwt #951TK2.8: add services args to observable routesTK2.8: add services args to observable routes #957TK2.9: add services arg to properties routesTK2.9: add services arg to properties routes #958TK2.10: add services args to version routesTK2.10: add services args to version routes #959TK2.11: add services args to entity.feedback routesTK2.11: add services args to entity.feedback routes #960TK2.12: add services args to entity.relationship routesTK2.12: add services args to entity.relationship routes #961TK2.15: Add services arg to entity-crud-routesTK2.15: Add services arg to entity-crud-routes #967TK3.1: add services args to flows.crudTK3.1: add services args to flows.crud #969 (depends on TK2.15)TK3.2: add services args to graphql routesTK3.2: add services args to graphql routes #970TK3.3: add service args to event hooks.event-hooksTK3.3: add service args to hooks.event-hooks #971TK3.4: add service args to get-http-showTK3.4: add service args to get-http-show #972TK3.5: add service args to get-access-controlTK3.5: add service args to get-access-control #975TK3.6: add service args to list-all-pagesTK3.6: add service args to list-all-pages #974TK3.7: miscTK3.7: misc #973TK3.8: change config "before" app starts in access-control-testTK3.8: change config "before" app starts in access-control-test #976TK3.9: add service args to ESConnStateTK3.9: add service args to ESConnState #984TK3.10: get-in-config in migration tests, better resource managementTK3.10: get-in-config in migration tests, better resource management #986TK3.11 misc TK prep for testsTK3.11 misc TK prep for tests #988TK3.11: Hooks serviceTK3.11: Hooks service #989TK3.12: GraphQL resolversTK3.12: GraphQL realize-fn #990Use fake TK app over global state several testsUse fake TK app over global state several tests #994Introduce trapperkeeper and port IAuth serviceIntroduce trapperkeeper and port IAuth service #995Port remaining 10 services to TrapperkeeperPort remaining 10 services to Trapperkeeper #997§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits