Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the temporal_severity field of the Vulnerability entity #249

Merged
merged 3 commits into from Sep 5, 2019
Merged

Fix the temporal_severity field of the Vulnerability entity #249

merged 3 commits into from Sep 5, 2019

Conversation

msprunck
Copy link
Contributor

@msprunck msprunck commented Sep 2, 2019

Fix the Vulnerability entity

Close threatgrid/iroh#2889

This PR sets the temporal_severity field as a CVSSv3Severity

§ QA

No QA needed

§ Release Notes

internal: Fix a the schema of the Vulnerability entity

@msprunck msprunck added the review label Sep 2, 2019
@msprunck msprunck self-assigned this Sep 2, 2019
yogsototh
yogsototh approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@yogsototh yogsototh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ereteog
ereteog approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@ereteog ereteog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gbuisson
gbuisson approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@gbuisson gbuisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msprunck msprunck merged commit 6c26585 into threatgrid:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogsototh yogsototh yogsototh approved these changes

@gbuisson gbuisson gbuisson approved these changes

@ereteog ereteog ereteog approved these changes

Assignees

@msprunck msprunck

Labels
No QA required review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msprunck @yogsototh @gbuisson @ereteog @NeelSaini