Added service_provider parameter with a default for Amazon Linux #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 4, 2020 14:03
|
thanks for the PR! i'm taking a look at these open PRs this week and will update. |
|
tested a bit locally, and this looks good to go. thanks again for submitting these changes! |
|
Sure thing, happy to contribute! |
|
@amlodzianowski oh, i just published 2.0.8 on the forge, too, if you want to pull from there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service was managed properly on Amazon Linux 201* instances, the default provider that Puppet chose was not able to ensure that service is running.
I also changed sysmonconfig-export.xml to use the remote_file resource since we were running into problems with the regular file resource with a masterless Puppet apply. I also removed the checksum check since the remote file is being automatically updated (last update 2020-01-16) and the checksum didn't match, causing failures.