Skip to content

Switch to RailsGravatar#889

Merged
glebm merged 1 commit into
thredded:masterfrom
mission-met:switch-to-railsgravatar
Apr 12, 2021
Merged

Switch to RailsGravatar#889
glebm merged 1 commit into
thredded:masterfrom
mission-met:switch-to-railsgravatar

Conversation

@rickychilcott

Copy link
Copy Markdown
Contributor

No description provided.

@rickychilcott

Copy link
Copy Markdown
Contributor Author

Well... hmm. I just cherry-picked the main commit and pulled against the latest master and everything seems OK.

@rickychilcott rickychilcott changed the title WIP Switch to RailsGravatar Switch to RailsGravatar Apr 11, 2021
@rickychilcott

Copy link
Copy Markdown
Contributor Author

Ok. I didn't wait long enough. I'll investigate further.

@rickychilcott
rickychilcott force-pushed the switch-to-railsgravatar branch from 3b846b5 to a5cce6a Compare April 11, 2021 16:25
@rickychilcott
rickychilcott force-pushed the switch-to-railsgravatar branch from a5cce6a to 2defedf Compare April 11, 2021 16:26
@rickychilcott

Copy link
Copy Markdown
Contributor Author

OK. I figured it out. It was fixed in RailsGravatar 1.0.4. I was using the Comparable#clamp method to conform the size param, but that wasn't released until Ruby 2.5. Also, I was rescuing all exceptions and just outputting nil if there was an error, which didn't surface the underlying issue.

That's all been fixed right now. CI is rerunning after a rebase and force push, but it will pass.

Ricky

@glebm
glebm merged commit 37faa5e into thredded:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants