Rails 7.2 Compatibility#985
Merged
glebm merged 3 commits intothredded:mainfrom Jul 17, 2024
Merged
Conversation
Contributor
Author
|
It's not currently fixing all of the issues. I'll ping back when I get it fully resolved. |
Contributor
Author
|
This is working for my purposes now. I haven't run the tests locally. @glebm can you have Travis run the test suite on this PR? |
Collaborator
|
Travis no longer works at all AFAIK. This repo needs to be migrated to GitHub Actions. For now, I'll merge the PR 👍 |
Contributor
Author
|
Thank you for merging so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to run
7.2.0.beta3on my app and ran into an issue. Namely, the syntax forenumdefinition has changed in Rails. This PR fixes the issue and adds testing for Rails 7.2 for Thredded.