Skip to content

Switch to GitHub Actions#987

Merged
glebm merged 36 commits into
thredded:mainfrom
mission-met:tech-debt/switch-to-gha
Jul 21, 2024
Merged

Switch to GitHub Actions#987
glebm merged 36 commits into
thredded:mainfrom
mission-met:tech-debt/switch-to-gha

Conversation

@rickychilcott
Copy link
Copy Markdown
Contributor

@rickychilcott rickychilcott commented Jul 18, 2024

Use a matrix-based approach to test Thredded. Ideally, this would test the following:

  • Latest Ruby versions
  • Highest Rails version (including edge)
  • With each major database provider (postgres, mysql, and sqlite)
  • Node version (currently only testing with version 14)

Addresses #986

@rickychilcott
Copy link
Copy Markdown
Contributor Author

rickychilcott commented Jul 18, 2024

@glebm or @timdiggins you may need to turn on GHA on the repository.

@rickychilcott
Copy link
Copy Markdown
Contributor Author

Nevermind. I think it's running...

@rickychilcott rickychilcott force-pushed the tech-debt/switch-to-gha branch 2 times, most recently from 6d62614 to ab35f65 Compare July 18, 2024 19:17
@rickychilcott rickychilcott force-pushed the tech-debt/switch-to-gha branch from ab35f65 to e52323b Compare July 18, 2024 19:19
@glebm
Copy link
Copy Markdown
Collaborator

glebm commented Jul 19, 2024

The actions are turned out but I don't see them running, odd

@rickychilcott
Copy link
Copy Markdown
Contributor Author

They're running on my repo right now. I think once this gets merged, it'll run on this repo

@timdiggins
Copy link
Copy Markdown
Collaborator

@rickychilcott brilliant - thanks for starting on this.

BTW I think we could drop rails 6.0 support as 6.0 has EOL'd (only if that helps!)

@rickychilcott rickychilcott force-pushed the tech-debt/switch-to-gha branch from 605f277 to 8ad0c67 Compare July 19, 2024 16:23
Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
Comment on lines +140 to +143
# - name: Test & publish code coverage
# uses: paambaati/codeclimate-action@v8.0.0
# env:
# CC_TEST_REPORTER_ID: <code_climate_reporter_id>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to get CodeClimate working again, then we'll need to determine the CC_TEST_REPORTER_ID: See https://docs.codeclimate.com/docs/finding-your-test-coverage-token

@rickychilcott
Copy link
Copy Markdown
Contributor Author

Happy Friday @glebm and @timdiggins! This appears to be passing and tests Rails 6.1+, all major ruby versions, and against all three database engines. We also have Rubocop and i18n-tasks checks in place.

I left a few comments that I'm looking for feedback on and then I think we can ship it.

See the CI runs at https://github.com/mission-met/thredded/actions. https://github.com/mission-met/thredded/actions/runs/10012043134 is the latest run that was successful.

I've experienced some flakiness on individual runs, most notably "Browser did not produce websocket url within 10 seconds, try to increase :process_timeout" issues. Which cac0a20 may or may not be improving.

@glebm
Copy link
Copy Markdown
Collaborator

glebm commented Jul 20, 2024

Fantastic work, thank you! The timeout issues could be due to the lack of onebox cache.

@rickychilcott
Copy link
Copy Markdown
Contributor Author

No problem, @glebm. Thank you for all of your work on this over the years. I think we're ready to merge.

@glebm glebm merged commit f776084 into thredded:main Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants