Switch to GitHub Actions#987
Conversation
|
@glebm or @timdiggins you may need to turn on GHA on the repository. |
|
Nevermind. I think it's running... |
6d62614 to
ab35f65
Compare
ab35f65 to
e52323b
Compare
… increase `:process_timeout`"
|
The actions are turned out but I don't see them running, odd |
|
They're running on my repo right now. I think once this gets merged, it'll run on this repo |
|
@rickychilcott brilliant - thanks for starting on this. BTW I think we could drop rails 6.0 support as 6.0 has EOL'd (only if that helps!) |
605f277 to
8ad0c67
Compare
| # - name: Test & publish code coverage | ||
| # uses: paambaati/codeclimate-action@v8.0.0 | ||
| # env: | ||
| # CC_TEST_REPORTER_ID: <code_climate_reporter_id> |
There was a problem hiding this comment.
If we want to get CodeClimate working again, then we'll need to determine the CC_TEST_REPORTER_ID: See https://docs.codeclimate.com/docs/finding-your-test-coverage-token
…pace changes [skip ci]
|
Happy Friday @glebm and @timdiggins! This appears to be passing and tests Rails 6.1+, all major ruby versions, and against all three database engines. We also have Rubocop and i18n-tasks checks in place. I left a few comments that I'm looking for feedback on and then I think we can ship it. See the CI runs at https://github.com/mission-met/thredded/actions. https://github.com/mission-met/thredded/actions/runs/10012043134 is the latest run that was successful. I've experienced some flakiness on individual runs, most notably "Browser did not produce websocket url within 10 seconds, try to increase |
|
Fantastic work, thank you! The timeout issues could be due to the lack of onebox cache. |
|
No problem, @glebm. Thank you for all of your work on this over the years. I think we're ready to merge. |
Use a matrix-based approach to test Thredded. Ideally, this would test the following:
Addresses #986