-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pytest #37
Fix pytest #37
Conversation
Ugh... Tests still fail. For python 2, tons of For python 3, 🙈 |
Ok. The good news is that the install seems to work & tests pass for python 3.7 (at least for macos). For python 2.7, there are still issues: In the Mac environment, the conda environment could not be resolved. In the linux one, conda installed a really old version of astromodels/threeML (and some other packages) for some reason, leading to compatibility issues down the line. I'm looking into it, but not sure what's going on. Do we need to keep python 2.7 support? |
Hi @henrikef, I think the reason is that the script is trying to install |
Thanks! I've been trying offline to get |
Mmh, interesting. Let me know if you need help with it. |
Hm. I tried with Any ideas? (This is on macOS 10.15.7). I attach the full output of both the conda install and the (failed) pip install below. |
Let me try on my laptop. |
I will go ahead and merge this one for now, as we were not able to get the python2 tests to pass offline either, but python 3 seems fine. |
Fix errors about "calling fixtures directly" in pytest. Tests pass for me locally now (except for one known failure in
test_geminga_paper
. Would be happy about feedback, I'm not an expert on pytest.