libzdb: fix invalid RSCAN on sequential database #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #146 reports an issue using sequential mode and RSCAN not returning sane values. This is confirmed. Code was still using old hardcoded fixed-length value (32 bits keys) not relevant anymore, but moreover was still using a dirty fix needed because of an old bug. This bug is probably not on the field anymore and can be discarded, this commit bypass that old hotfix and use a more classic/logic way how to deal RSCAN. Code will be cleaned after more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #146,
RSCANis not returning sane data in sequential database. This is caused by old dirty code supposed to fix mistake on old database, we drop that support since it's not used and probably not in the field and if it it, please migrate your database to a new version.