cleaning up network namespace after deleting container #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaibon
requested review from
LeeSmet,
delandtj,
maxux and
muhamadazmy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 48.56% 48.56%
=======================================
Files 37 37
Lines 2432 2432
=======================================
Hits 1181 1181
Misses 1114 1114
Partials 137 137Continue to review full report at Codecov.
|
muhamadazmy
approved these changes
Oct 10, 2019
Member
muhamadazmy
left a comment
muhamadazmy
left a comment
There was a problem hiding this comment.
LGTM. Only on comment (may be later)
The containerProvision should also take care to leave if an error occured in the provision process after the join call was made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #314