Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display empty battery notification when charging #359

Closed
Elsensee opened this issue Oct 17, 2017 · 1 comment
Closed

Don't display empty battery notification when charging #359

Elsensee opened this issue Oct 17, 2017 · 1 comment
Labels
bug It's a bug! good first issue If you want to get your hands dirty, this is a good start!

Comments

@Elsensee
Copy link

Expected Behavior

A push notification for empty battery should only be displayed when the battery is empty AND the device is not charging.

Current Behavior

A push notification for empty battery is displayed if the battery is empty no matter if it is plugged or not.

Steps to Reproduce (for bugs)

  1. Use your phone until its battery is below 19%
  2. Plug your phone to the charger and open Threema Web

Your Environment

  • Threema Web version: 1.6.1
  • Threema for Android version: 3.21.2000380
  • Threema for Android source: Play Store
  • Browser name and version: Chrome 62
  • Operating system and version: Ubuntu 17.04
@Elsensee Elsensee changed the title Don't display battery empty notification when charging Don't display empty battery notification when charging Oct 17, 2017
@dbrgn dbrgn added bug It's a bug! good first issue If you want to get your hands dirty, this is a good start! labels Oct 18, 2017
@dbrgn
Copy link
Contributor

dbrgn commented Oct 18, 2017

Thanks, that somehow slipped through :) Fixed in #360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug! good first issue If you want to get your hands dirty, this is a good start!
Development

No branches or pull requests

2 participants