Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable Reconnection #802

Open
lgrahl opened this issue May 13, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@lgrahl
Copy link
Contributor

commented May 13, 2019

This is an umbrella issue that tracks known issues related to reconnection attempts which need resolving before we can release the reconnect overhaul code introduced by #792. The rationale here is that the multiple pushes trigger race conditions in both the iOS and the Android app (which is good because at least we can now reproduce them better).

This issue is not intended for discussion. If you encounter further issues you suspect are not listed here or you have new insights, please file a new issue.

Threema Web

  • #799: Investigate why it causes these UI issues (PR: #803)
  • #812, #818: Issues with the state machine (also, orange bar phenomenon when there's no internet connection).

SaltyRTC Client JS

SaltyRTC Client Java

SaltyRTC Client Rust

Android App

  • Must not establish multiple SaltyRTC connections of the same session (internal: ANDR-909).
  • Must not wait until a previous SaltyRTC connection has been stopped / a timer fired when the affiliation id of the push (wca) is different. It should discard the connection and restart the web client session immediately (internal: ANDR-908).
  • Must ignore pushes with the same affiliation id (wca) when it is already connected or currently establishing a connection with that id (internal: ANDR-909).
  • Must not ignore pending wakeups (internal: ANDR-914).
  • Release.

iOS App

  • Must not wait until a previous SaltyRTC connection has been stopped / a timer fired when the affiliation id of the push (wca) is different. It should discard the connection and restart the web client session immediately (internal: IOS-751).
  • Must ignore pushes with the same affiliation id (wca) when it is already connected or currently establishing a connection with that id (internal: IOS-751).
  • Release.

@lgrahl lgrahl referenced this issue May 13, 2019

Merged

Reconnect overhaul #792

5 of 5 tasks complete

@lgrahl lgrahl removed bug ui labels May 13, 2019

@lgrahl lgrahl pinned this issue May 13, 2019

lgrahl added a commit that referenced this issue Jun 12, 2019

@lgrahl lgrahl referenced this issue Jun 12, 2019

Merged

Push once... #816

lgrahl added a commit that referenced this issue Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.