Fix scroll glue behavior #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Feel free to test at https://threema-web.vortex852456.de/ |
|
Thanks, I'll test this for a while! |
dbrgn
changed the title
|
Seems to work nicely so far, haven't noticed big performance issues! I'd say let's promote this to Thanks, @vortex852456! |
dbrgn
reviewed
Nov 12, 2019
dbrgn
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The throttleling of the scroll event causes the behavior in issue #18.
But to be able to detach from bottom-glue without throtteling, updateScrollJump() must already have set showScrollJump to true when there is scrolled more than one pixel.
I guess this solution is not optimal for performance, but I have no problems in my browser.
It's much better than living with the scroll-glue bug, though.