From c3b70ac67a88e2d041e5a1ba418ae7b0c327bcf2 Mon Sep 17 00:00:00 2001 From: Gary Woodfine Date: Mon, 25 Oct 2021 14:04:27 +0100 Subject: [PATCH] Refactored to include more Explicity ListResponse and SingleResponse object --- src/Threenine.ApiResponse/Response.cs | 17 ----------------- src/Threenine.ApiResponse/SingleResponse.cs | 13 +++++++++++++ .../ResponseTests.cs | 17 ++--------------- 3 files changed, 15 insertions(+), 32 deletions(-) delete mode 100644 src/Threenine.ApiResponse/Response.cs create mode 100644 src/Threenine.ApiResponse/SingleResponse.cs diff --git a/src/Threenine.ApiResponse/Response.cs b/src/Threenine.ApiResponse/Response.cs deleted file mode 100644 index 4d8ba17..0000000 --- a/src/Threenine.ApiResponse/Response.cs +++ /dev/null @@ -1,17 +0,0 @@ -using System.Collections.Generic; - -namespace Threenine.ApiResponse -{ - public class Response : BaseResponse, ISingleResponse where TModel : class - { - public Response(TModel model, IList validationErrors = null) : base(validationErrors) - { - Item = model; - } - - - - public IList Links { get; set; } - public TModel Item { get; } - } -} \ No newline at end of file diff --git a/src/Threenine.ApiResponse/SingleResponse.cs b/src/Threenine.ApiResponse/SingleResponse.cs new file mode 100644 index 0000000..36c702a --- /dev/null +++ b/src/Threenine.ApiResponse/SingleResponse.cs @@ -0,0 +1,13 @@ +using System.Collections.Generic; + +namespace Threenine.ApiResponse +{ + public class SingleResponse : BaseResponse, ISingleResponse where TModel : class + { + public SingleResponse(TModel model, IList validationErrors = null) : base(validationErrors) + { + Item = model; + } + public TModel Item { get; } + } +} \ No newline at end of file diff --git a/tests/Threenine.ApiResponse.Tests/ResponseTests.cs b/tests/Threenine.ApiResponse.Tests/ResponseTests.cs index fa208b6..af2d160 100644 --- a/tests/Threenine.ApiResponse.Tests/ResponseTests.cs +++ b/tests/Threenine.ApiResponse.Tests/ResponseTests.cs @@ -10,23 +10,10 @@ public class ResponseTests [Fact] public void Should_have_default_properties() { - var testClass = new Response(null); + var testClass = new SingleResponse(null); testClass.Item.ShouldBeAssignableTo(); - testClass.Links.ShouldBeAssignableTo>(); - } - - [Fact] - public void Should_return_links_list() - { - var testClass = new Response(null) - { - Links = Builder.CreateListOfSize(4).Build() - - }; - - testClass.Links.ShouldBeAssignableTo>(); - testClass.Links.Count.ShouldBe(4); + } }