ERR_MODULE_NOT_FOUND when building static app

[richiejp]

Hi,

I found when trying to build my threlte based app for static deployment that I got an error similar to the following: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '<...>/node_modules/three/examples/jsm/postprocessing/EffectComposer' imported from <...>/.svelte-kit/output/server/entries/pages/index.svelte.js Did you mean to import three/examples/jsm/postprocessing/EffectComposer.js?

I saw that in threlte's svelte.config.js there are some extra vite options for threejs. It seems that adding the following "fixes" the issue:

		  ssr: {
		    noExternal: ['three']
		  }

However then index.svelte.js balloons to 1105.56KiB from 63.85KiB. This is not a big deal IMO. However are there any plans/ideas to fix this?

[grischaerbe]

three.js in its nature is apparently hard to treehshake. You could try using this plugin for vite to minify three.js: https://github.com/yushijinhun/three-minifier.
Let me know if it works, that would be great!

[richiejp]

Thanks, it seems to work, I still need to mark threejs as noExternal, however during the build it now says the index.svelte.js is 301.93KiB. The end result is this removes about 200KiB from the uncompressed JS.

[grischaerbe]

Thanks! I'll update the Docs accordingly!

[grischaerbe]

@richiejp Do you think that's sufficient? I saw that svelte-cubed also excludes three.js from vites optimization step, not sure if that is necessary. Do you have any insights on that?

[richiejp]

FWIW I think so. I'm not sure what these things do though.

…

-- Richard Palethorpe ***@***.***

On Fri, 28 Jan 2022, at 20:06, Grischa Erbe wrote: @richiejp <https://github.com/richiejp> Do you think that's sufficient <https://github.com/grischaerbe/threlte#getting-started>? I saw that svelte-cubed also excludes three.js from vites optimization step, not sure if that is necessary. Do you have any insights on that? — Reply to this email directly, view it on GitHub <https://github.com/grischaerbe/threlte/issues/8#issuecomment-1024597314>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRHQUX5IIRNFF5J6TXVRTUYLZL3ANCNFSM5NALYOGQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>