New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password cases possible fix #7

Merged
merged 3 commits into from Dec 3, 2012

Conversation

Projects
None yet
2 participants
@jamescooke
Contributor

jamescooke commented Nov 30, 2012

Have removed the lower case formatting that occurs on raw passwords which appears to fix the tests provided here: #5

Hope that's a nice and safe solution.

Apologies for spamming the pull requests.

@thruflo

This comment has been minimized.

Show comment
Hide comment
@thruflo

thruflo Dec 3, 2012

Owner

Hi @jamescooke thanks again for this one too. This does change the api, in that previously the intention was to lower case passwords. I think that's a bad idea though, i.e.: it's better to allow users to use upper and lower case letters meaningfully in passwords.

I'll merge and bump the version to indicate the api change.

Owner

thruflo commented Dec 3, 2012

Hi @jamescooke thanks again for this one too. This does change the api, in that previously the intention was to lower case passwords. I think that's a bad idea though, i.e.: it's better to allow users to use upper and lower case letters meaningfully in passwords.

I'll merge and bump the version to indicate the api change.

thruflo added a commit that referenced this pull request Dec 3, 2012

Merge pull request #7 from jamescooke/jc/password-cases
schema: stop forcing passwords to lower case.

@thruflo thruflo merged commit 01efe1e into thruflo:master Dec 3, 2012

@jamescooke jamescooke deleted the jamescooke:jc/password-cases branch Jan 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment