Password cases possible fix #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jamescooke thanks again for this one too. This does change the api, in that previously the intention was to lower case passwords. I think that's a bad idea though, i.e.: it's better to allow users to use upper and lower case letters meaningfully in passwords. I'll merge and bump the version to indicate the api change. |
thruflo
added a commit
that referenced
this pull request
Dec 3, 2012
schema: stop forcing passwords to lower case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have removed the lower case formatting that occurs on raw passwords which appears to fix the tests provided here: #5
Hope that's a nice and safe solution.
Apologies for spamming the pull requests.