Switch from pyvows to nosetest #139
Conversation
| storage.put(IMAGE_BYTES, callback=callback) | ||
|
|
||
| def should_be_in_catalog(self, topic): | ||
| expect(topic.args[0]).to_equal([sha1('my-image.jpg'.encode('utf8')).hexdigest(), 'my-image.jpg'].join('/')) |
There was a problem hiding this comment.
This line has error. list does not have method join. So this test should be always failing. However it was doing in CI. There were few other similar tests which test non-existing return of a function, etc.
That all makes me think that vows were not testing anything really, just exceptions thrown in topic stage would trigger test failure, but should_ methods never worker, it seems.
There was a problem hiding this comment.
Yeah there were a few issues indeed. Thanks a lot for switching the lib :)
|
Wow great work, thanks a lot! Looks good so far, there's only one test failing in the CI, would you mind looking into it? https://circleci.com/gh/thumbor-community/aws/248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
|
@Bladrak test fixed, should be good to go. |
|
Thanks, I'm away from computers at the moment but I'll take a look when I can, in a few days.
|
|
@kkopachev Merged, however the build seems to be failing, would you mind checking it? |
|
Looks like it fails to checkout from git. Maybe you rotated your ssh key? |
|
Hmm no but looks like it's an issue with the docker image, checking it. I'll let you know |
Figured we should switch to nosetests from pyvows.