New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tornado's AsyncHttpClient #38

Closed
ianlewis opened this Issue Apr 29, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@ianlewis

ianlewis commented Apr 29, 2011

Currently thumbor's http_loader can only download one file at a time because it uses tornado's blocking http client. This causes image downloads to take a lot longer than they should.

You should pass a callback to the loader which will be called to process the image once the download is complete.

There isn't much point to your using tornado currently since you are blocking when loading images.

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Apr 29, 2011

Member

Can you provide a patch via pull request? We'd love to have you as a contributor!

Member

heynemann commented Apr 29, 2011

Can you provide a patch via pull request? We'd love to have you as a contributor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment