New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mimetype from remote http response instead of file extension #45

Merged
merged 9 commits into from Oct 14, 2011

Conversation

Projects
None yet
2 participants
@stefanocavallari
Contributor

stefanocavallari commented Sep 12, 2011

the sql and redis storages still need to be modified.
Everything seems to work otherwhise.

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Sep 20, 2011

Member

Stefano, I did not forget about your pull request... We are just going
through a tough phase here at work right now and didn't have time to merge
it...

Sorry about that! Hope it does not discourage you from future patches! :)

Cheers,
Bernardo Heynemann

On Mon, Sep 12, 2011 at 5:46 PM, Stefano Cavallari <
reply@reply.github.com>wrote:

the sql and redis storages still need to be modified.
Everything seems to work otherwhise.

You can merge this Pull Request by running:

git pull https://github.com/spikykiwi/thumbor master

Or you can view, comment on it, or merge it online at:

#45

-- Commit Summary --

  • first attempt to detect mimetype from headers and ignore extension
  • file storage store and reads mimetype
  • mongodb storage, untested
  • no_storage patched for mimetype
  • test and cleanup mongodb storage
  • updated mixed storage with mimetype
  • removed unused code

-- File Changes --

M thumbor/handlers/init.py (38)
M thumbor/loaders/http_loader.py (6)
M thumbor/storages/file_storage.py (19)
M thumbor/storages/mixed_storage.py (4)
M thumbor/storages/mongo_storage.py (21)
M thumbor/storages/no_storage.py (4)

-- Patch Links --

https://github.com/globocom/thumbor/pull/45.patch
https://github.com/globocom/thumbor/pull/45.diff

Reply to this email directly or view it on GitHub:
#45

Member

heynemann commented Sep 20, 2011

Stefano, I did not forget about your pull request... We are just going
through a tough phase here at work right now and didn't have time to merge
it...

Sorry about that! Hope it does not discourage you from future patches! :)

Cheers,
Bernardo Heynemann

On Mon, Sep 12, 2011 at 5:46 PM, Stefano Cavallari <
reply@reply.github.com>wrote:

the sql and redis storages still need to be modified.
Everything seems to work otherwhise.

You can merge this Pull Request by running:

git pull https://github.com/spikykiwi/thumbor master

Or you can view, comment on it, or merge it online at:

#45

-- Commit Summary --

  • first attempt to detect mimetype from headers and ignore extension
  • file storage store and reads mimetype
  • mongodb storage, untested
  • no_storage patched for mimetype
  • test and cleanup mongodb storage
  • updated mixed storage with mimetype
  • removed unused code

-- File Changes --

M thumbor/handlers/init.py (38)
M thumbor/loaders/http_loader.py (6)
M thumbor/storages/file_storage.py (19)
M thumbor/storages/mixed_storage.py (4)
M thumbor/storages/mongo_storage.py (21)
M thumbor/storages/no_storage.py (4)

-- Patch Links --

https://github.com/globocom/thumbor/pull/45.patch
https://github.com/globocom/thumbor/pull/45.diff

Reply to this email directly or view it on GitHub:
#45

heynemann added a commit that referenced this pull request Oct 14, 2011

Merge pull request #45 from spikykiwi/master
use mimetype from remote http response instead of file extension

@heynemann heynemann merged commit f742490 into thumbor:master Oct 14, 2011

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Oct 14, 2011

Member

Thanks a lot and really sorry for the time it took us to merge it.

Cheers,
Bernardo Heynemann

Member

heynemann commented Oct 14, 2011

Thanks a lot and really sorry for the time it took us to merge it.

Cheers,
Bernardo Heynemann

@stefanocavallari

This comment has been minimized.

Show comment
Hide comment
@stefanocavallari

stefanocavallari Oct 21, 2011

Contributor

What happened to the patch? I see it was reverted. Are there problems in it?

Contributor

stefanocavallari commented Oct 21, 2011

What happened to the patch? I see it was reverted. Are there problems in it?

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Oct 21, 2011

Member

We found a better way of doing it using libmagic. But we found some issues
with it regarding the other storages.

Sorry to have reverted it without telling you, but we had to quickly solve
bugs in prod.

Cheers,
Bernardo Heynemann

On Friday, October 21, 2011, Stefano Cavallari <
reply@reply.github.com>
wrote:

What happened to the patch? I see it was reverted. Are there problems in
it?

Reply to this email directly or view it on GitHub:
#45 (comment)

Bernardo Heynemann
Developer @ globo.com

Member

heynemann commented Oct 21, 2011

We found a better way of doing it using libmagic. But we found some issues
with it regarding the other storages.

Sorry to have reverted it without telling you, but we had to quickly solve
bugs in prod.

Cheers,
Bernardo Heynemann

On Friday, October 21, 2011, Stefano Cavallari <
reply@reply.github.com>
wrote:

What happened to the patch? I see it was reverted. Are there problems in
it?

Reply to this email directly or view it on GitHub:
#45 (comment)

Bernardo Heynemann
Developer @ globo.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment