New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache-Control and Expires HTTP headers in response #53

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dhardy92
Contributor

dhardy92 commented Dec 29, 2011

Hello,

This is a small patch to add some cache control in configuration.
If you use some caching technologies like varnishd in front of thumbor it could be usefull to add Cache-Control and Expires header to make varnish storing fine the generated image preventing request at thumbor to often.

I add some tests with it but wasn't able to make them working, all the tests ends with :
AssertionError: Async operation timed out after X seconds
Did I missed something ?

Best regards,

Damien

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Dec 29, 2011

Member

Thanks a LOT Damien. We'll integrate asap.

Cheers,
Bernardo Heynemann

On Thu, Dec 29, 2011 at 1:44 PM, Damien Hardy <
reply@reply.github.com

wrote:

Hello,

This is a small patch to add some cache control in configuration.
If you use some caching technologies like varnishd in front of thumbor it
could be usefull to add Cache-Control and Expires header to make varnish
storing fine the generated image preventing request at thumbor to often.

I add some tests with it but wasn't able to make them working, all the
tests ends with :
AssertionError: Async operation timed out after X seconds
Did I missed something ?

Best regards,

Damien

You can merge this Pull Request by running:

git pull https://github.com/dhardy92/thumbor master

Or you can view, comment on it, or merge it online at:

#53

-- Commit Summary --

  • add optional Cache-Control and Expires HTTP headers in response

-- File Changes --

M tests/test_handlers.py (11)
M thumbor/config.py (1)
M thumbor/handlers/init.py (5)

-- Patch Links --

https://github.com/globocom/thumbor/pull/53.patch
https://github.com/globocom/thumbor/pull/53.diff


Reply to this email directly or view it on GitHub:
#53

Member

heynemann commented Dec 29, 2011

Thanks a LOT Damien. We'll integrate asap.

Cheers,
Bernardo Heynemann

On Thu, Dec 29, 2011 at 1:44 PM, Damien Hardy <
reply@reply.github.com

wrote:

Hello,

This is a small patch to add some cache control in configuration.
If you use some caching technologies like varnishd in front of thumbor it
could be usefull to add Cache-Control and Expires header to make varnish
storing fine the generated image preventing request at thumbor to often.

I add some tests with it but wasn't able to make them working, all the
tests ends with :
AssertionError: Async operation timed out after X seconds
Did I missed something ?

Best regards,

Damien

You can merge this Pull Request by running:

git pull https://github.com/dhardy92/thumbor master

Or you can view, comment on it, or merge it online at:

#53

-- Commit Summary --

  • add optional Cache-Control and Expires HTTP headers in response

-- File Changes --

M tests/test_handlers.py (11)
M thumbor/config.py (1)
M thumbor/handlers/init.py (5)

-- Patch Links --

https://github.com/globocom/thumbor/pull/53.patch
https://github.com/globocom/thumbor/pull/53.diff


Reply to this email directly or view it on GitHub:
#53

@heynemann heynemann closed this Jan 12, 2012

@heynemann

This comment has been minimized.

Show comment
Hide comment
@heynemann

heynemann Jan 12, 2012

Member

Implemented this on master.

Thanks a LOT for contributing.

Member

heynemann commented Jan 12, 2012

Implemented this on master.

Thanks a LOT for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment