Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add MP4 engine to support producing webp/gif directly from mp4 #899
In the PR, I implemented a new engine for producing
I have an original idea that transcode video into gifs, but the gifs are too large and bad in quality.
I also considered saving the
I started learning Python only a few days ago and had never wrote so much Python, please help to correct me if I made any stupid mistakes.
Heya @winguse! Thanks for this PR!
First of all, gratz for you first Python code :) Way to go!
We've been talking about a better way of adding new Engines to Thumbor, but the actual code has some issues that needs to be addressed first. Right now, through configuration, we are only able to change an Engine for all images or change an Engine for gifs, separately. The only way to add a brand new Engine for another mimetype is, as this PR did, adding another if to the
Config.define( 'ENGINES', [ ('video/mp4', 'thumbor.engines.mp4'), ('image/gif', 'thumbor.engines.gif'), ('default', 'thumbor.engines.pil'), ]
With that being said, I'd like to propose that:
1- This PR would be only about adding a new mp4 Engine.
I'll take care of 3 and will link it in here ASAP.
Then again, thank you for the PR and keep up the good work!