Permalink
Browse files

Add more meaningful variable names

  • Loading branch information...
1 parent a955580 commit 758a94255f5dbd2f42dad357e5084133bec03fcc Rishi Bajekal committed Aug 1, 2012
Showing with 4 additions and 4 deletions.
  1. +2 −2 abba/render.js
  2. +2 −2 abba/stats.js
View
@@ -280,7 +280,7 @@ Abba.ResultsPresenter.prototype = {
var baselineProportion = experiment.getBaselineProportion();
var overallConversionBounds = {lowerBound: baselineProportion.lowerBound,
upperBound: baselineProportion.upperBound};
- var vars = variations.map(function(variation) {
+ var variationResults = variations.map(function(variation) {
var outcome = experiment.getResults(variation.numSuccesses, variation.numTrials);
overallConversionBounds.lowerBound = Math.min(overallConversionBounds.lowerBound,
outcome.proportion.lowerBound);
@@ -292,7 +292,7 @@ Abba.ResultsPresenter.prototype = {
return {
baselineProportion: baselineProportion,
overallConversionBounds: overallConversionBounds,
- variations: vars
+ variations: variationResults
};
},
View
@@ -276,8 +276,8 @@ Abba.Experiment = function(numVariations, baselineNumSuccesses, baselineNumTrial
this._baseline = new Abba.Proportion(baselineNumSuccesses, baselineNumTrials);
this._numComparisons = Math.max(1, numVariations);
- var alpha = intervalAlpha / this._numComparisons; // Bonferroni correction
- this._intervalZCriticalValue = normal.inverseSurvival(alpha / 2);
+ var correctedAlpha = intervalAlpha / this._numComparisons; // Bonferroni correction
+ this._intervalZCriticalValue = normal.inverseSurvival(correctedAlpha / 2);
};
Abba.Experiment.prototype = {
getBaselineProportion: function() {

0 comments on commit 758a942

Please sign in to comment.