Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation with deferred comments #749

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix animation with deferred comments #749

merged 1 commit into from
Sep 22, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 19, 2023 •
edited

Pull Request Description

This PR fixes an issue where the collapse/expand animation did not work for the deferred comments indicator.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_ucdKvmD5dL.mp4

After

qemu-system-x86_64_cMSqbucaWk.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo mentioned this pull request Sep 20, 2023
Merged
hjiangsu
hjiangsu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but its interesting why adding a Column fixes the issue

@hjiangsu hjiangsu merged commit 274f6fd into thunder-app:develop Sep 22, 2023
1 check passed
@micahmo
Copy link
Member Author

micahmo commented Sep 23, 2023

its interesting why adding a Column fixes the issue

Yeah I couldn't figure out what the problem was and kind of stumbled upon that accidentally. Oh well! 🤷😆

@micahmo micahmo deleted the fix/deferred-animation branch September 23, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahmo @hjiangsu