Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance page #824

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 12, 2023

Pull Request Description

This PR introduces a very simple instance page. Currently it is only accessible from the post long-press menu and essentially only displays the instance heading and sidebar. It does also have the option to open the instance in the browser.

This should provide a groundwork for many other things such as...

  • a place to block an instance
  • the ability to open this page from many other places (e.g., account switcher)
  • seeing a list of communities on an instance

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_3Q2eV6vMik.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo mentioned this pull request Oct 17, 2023
8 tasks
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, I just had a few comments/feedback on some minor points!

lib/instance/instance_page.dart Outdated Show resolved Hide resolved
lib/l10n/app_es.arb Outdated Show resolved Hide resolved
lib/utils/navigate_instance.dart Outdated Show resolved Hide resolved
lib/instance/instance_view.dart Outdated Show resolved Hide resolved
@micahmo micahmo requested a review from hjiangsu October 19, 2023 02:55
@hjiangsu hjiangsu merged commit b199d28 into thunder-app:develop Oct 19, 2023
1 check passed
@micahmo micahmo deleted the feature/instance-page branch October 19, 2023 17:54
@micahmo micahmo mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants