Show cross-posts #851
Show cross-posts #851
Conversation
|
Updated with the create cross-post functionality in 8616c54, so I'm taking this out of draft status. qemu-system-x86_64_hhqOOw4Psn.mp4 |
|
This should be good to go! |
lib/post/widgets/post_view.dart
Outdated
| child: CommonMarkdownBody( | ||
| body: post.body ?? '', | ||
| ), | ||
| ), | ||
| if (showCrossPosts && sortedCrossPosts.isNotEmpty) | ||
| Padding( |
There was a problem hiding this comment.
It might be good to separate this into its own widget just for organization purposes (the widget can reside in this file, but just moved out of the PostView widget - to see what I mean by this, you can check out Tagline on the FeedPage)
There was a problem hiding this comment.
Good idea! All set to go now!
Yeah I know, maybe it's overkill. I can just see potential for it being annoying to clutter the post view. 🤷 Regardless it's on by default. Maybe at some point we'll have an advanced settings area for much more granular things that the majority of people won't touch. I can see a lot of the current enhancement requests fitting in this category. 😆 |
|
Looks good, thanks for the changes! |
Pull Request Description
This PR adds support for displaying, navigating to, and creating cross-posts.
The new UI optionally lists all the communities to which the same link has been posted, allowing you to navigate to any of them. You can also create a new cross-posts, which simply populates the new post UI with the link and title from the existing one.
Issue Being Fixed
Related to #469, but doesn't de-dup. I wonder if we really want de-duping anyway since each version of the post has its own set of unique comments for its community.
Screenshots / Recordings
qemu-system-x86_64_eVUYxYX8FV.mp4
Checklist
semanticLabels where applicable for accessibility?