Display the latest compatible version of an add-on, instead of the latest

[darktrojan]

This checks the user agent string for Thunderbird versions numbers, and compares them to the compatible versions for the add-on. It should allow add-on authors to upload beta-compatible versions without the add-on being shown as incompatible with ESR versions. At least in the detail view, for now.

[Sancus]

I'll have to examine this when I'm back next week, but doing it only on the detail view seems super sketchy and confusing given that you typically decide to install an add-on from the search list or the discovery pane, not from the detail view.

[darktrojan]

I think it actually happens in all the views, and I'm trying to check that now, but my install is putting up a fight and won't start properly.

[Sancus]

This is on stage now, along with a lot of upstream commits.

So if I'm understanding this patch right, it should show the newest compatible version for your client version based on the Thunderbird user agent?

So test procedure should be:

1. Set addons.thunderbird.net to 52.37.58.53 in /etc/hosts
2. Search for an add-on in the discovery page, that has a version uploaded for TB60.* and one for TB65 or something.
3. See if the appropriate version shows up in each client version.

I feel like this might produce issues on the site when people visit it in Firefox though. For example, if you have a current version for 60.* and you upload a version for TB65, that will be the "newest version" according to the site, and so people won't be able to download the version for release via Firefox/Chrome without going into the version history(which they probably won't realize they have to do).

[Sancus]

I merged this manually and resolved the conflicts before testing it. cf94571

[darktrojan]

Sorry, haven't had time to deal with this.

I feel like this might produce issues on the site when people visit it in Firefox though. For example, if you have a current version for 60.* and you upload a version for TB65, that will be the "newest version" according to the site, and so people won't be able to download the version for release via Firefox/Chrome without going into the version history(which they probably won't realize they have to do).

That's already the case, so at least we're not making things any worse. Perhaps there needs to be a setting for whatever is the current version, and use that when the UA string isn't from Thunderbird.

[Sancus]

Yes, I'm going to push this and your other PRs live tomorrow morning. It doesn't make the experience worse, at least, so I think it's fine. I tested it all on stage a while ago.

My main problem with it is that I think encouraging add-on authors to upload beta versions still creates a bad experience if you're not visiting the site in Thunderbird. That's probably how the vast majority of people install add-ons though, so I'm not too worried about it.

There is a 'current version' right now it's just that there's no easy way for an author to change it, it's just automatically changed whenever an approved version is added or one is deleted/unapproved.

I'm not sure if adding UI for that is even worth it, really. I guess it depends on how many times we're going to universally break add-on backwards compatibility in betas. Hopefully we won't make a habit of it.

[darktrojan]

I meant the current version of Thunderbird.