Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TOP_LEVEL_DOMAIN_STR_FOR_WEB_URL to match more new TLDs #1617

Merged
merged 1 commit into from Oct 5, 2016

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Sep 18, 2016

new regex produced by https://github.com/irccloud/android/blob/master/make-iana-tld-pattern.py cbe04ae

I had the problem that 'http://example.consultig/' was not shown as link.

This will probably also fix #1497

@philipwhiuk
Copy link
Contributor

philipwhiuk commented Sep 19, 2016

I'm not opposed to this being merged as a improvement but I do think it's untenable. We don't try and filter actual domains like this and I'm unconvinced it's now practical to match TLDs given the generics that are now present.

Hence the comments on #1223 regarding removing the regex entirely.

@helmo
Copy link
Contributor Author

helmo commented Sep 20, 2016

yes, +1 for using a library for that. I just hope there's someone with time to do that.

@cketti
Copy link
Member

cketti commented Sep 20, 2016

I imagine this has some performance implications. Did you test this against a text body of say 500kb?

@helmo
Copy link
Contributor Author

helmo commented Sep 21, 2016

@cketti cketti merged commit c905b30 into thundernest:master Oct 5, 2016
@cketti
Copy link
Member

cketti commented Oct 5, 2016

We'll just use the alpha versions to test the performance in "production".

@cketti
Copy link
Member

cketti commented Oct 5, 2016

@helmo: Thanks for the pull request!

@philipwhiuk
Copy link
Contributor

philipwhiuk commented Oct 6, 2016

If this works fine, one possibility is to have make-iana-tld-pattern.py as part of our build process so it automatically includes new ones when we do a release.

@cketti
Copy link
Member

cketti commented Oct 6, 2016

@philipwhiuk: I want us to move away from using regular expressions to detect URIs. See #1223 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some TLDs are not converted to links when using plain text
3 participants