Use API request to determine if user can leave or disband a team #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these are used to check if the authenticated user can leave the team (team needs to retain at least one owner) and if the team can be disanded (team with packages can't be disbanded).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
apps/cyberstorm-remix/app/settings/teams/team/tabs/Settings/Settings.tsx
Fixed
Show fixed
Hide fixed
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1637 +/- ##
=========================================
+ Coverage 9.86% 9.95% +0.09%
=========================================
Files 313 314 +1
Lines 22537 22606 +69
Branches 409 411 +2
=========================================
+ Hits 2223 2251 +28
- Misses 20314 20355 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There's no longer need to check if currentUser is set in the session context as the API call will return 401 that gets handled automatically (currently by showing 500 error but better once the global error handling PR is merged) if the user isn't authenticated. There's no need to wait for the teamName to resolve as it's resolved synchronously (based on the team name in the route URL), i.e. no Promise is returned.
While a simple thing to check, this gets repeated constantly so having a dedicated helper with basic unit tests in place makes sense.
Use actual permission checks to show content instead of hardcoding it. Try to remove repetitive text on the page. If user can perform the action, only show the button to do so, and show clarification texts in the modal. Show why user can't perform an operation only if they actually can't do so. Change alert boxes from "danger" to "info", since it looked like there was some sort of error preventing user from performing the operations, while the system is working just as intended. Update the "how to disband team if team has packages" text to match (roughly) what's on the legacy website. Contacting Mythic does nothing.
anttimaki
force-pushed
the
team-settings-pt5-disband
branch
from
c06253e to
53b482d
Compare
Oksamies
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.