GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
In the recent commit, all PHP tags (<?php) were changed to PHP short tags (<?). This change makes the extension LESS useful as not all servers with PHP will support the short tag.
Please PLEASE roll back this commit.
In addition to this[http://stackoverflow.com/questions/200640/are-php-short-tags-acceptable-to-use] good discussion about php short tags, they are enabled by default since php 5.4:
I understand the desire to use short tags, however as a production developer I have to disagree. While short tags are increasing in support, if you are developing code for others to use, you should be making it as easy as possible for as many as possible to use your code. This change makes it harder for many to use this extension, and serves no purpose apart from saving a few KB. The requirement for Yii is PHP 5.2, and PHP 5.4 is rarely available on commercial hosting services. Even still, this change goes against the concept of 'maximum compatibility' that should be employed when writing code for others to use. Sure, it's easy enough to do a find and replace, by why make potential users do that? What purpose does it serve?
In addition, that discussion on stackoverflow seems genuinely split, with even advocates of short tags acknowledging that unless you have complete control of your hosting environment, you should use long tags. Since you're writing an extension with absolutely no knowledge of the target environment, let alone control, wouldn't it be prudent to use long tags?
How about this compromise:
In git, for development, we use short <? tags. As soon as we do a packaged release, i
include the <?php tags for deployment on foreign hosters.
Speaking about that; its time for another release ;)
That sounds like an acceptable compromise :)