Merged
Conversation
$sysmis is supposed to be a floating-point value that, when written to an SPSS system file, represents the system-missing value. The previous value was incorrect: when written to a system file, it yielded the bytes fe ff ff ff ff ff ef c3, instead of the correct bytes ff ff ff ff ff ff ef ff. This was because of the difference between integer and floating point: when -0xFFFFFFFFFFFFEFFF is converted to an IEEE-754 "double", the bit representation changes. This commit corrects the problem, as can be observed by running test_write.php and observing the bytes written in the machine floating point record at offset 0xb40.
tiamo
added a commit
that referenced
this pull request
Sep 4, 2015
SPSSWriter: Fix value of $sysmis.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$sysmis is supposed to be a floating-point value that, when written to an
SPSS system file, represents the system-missing value. The previous value
was incorrect: when written to a system file, it yielded the bytes
fe ff ff ff ff ff ef c3, instead of the correct bytes
ff ff ff ff ff ff ef ff. This was because of the difference between
integer and floating point: when -0xFFFFFFFFFFFFEFFF is converted to an
IEEE-754 "double", the bit representation changes. This commit corrects
the problem, as can be observed by running test_write.php and observing
the bytes written in the machine floating point record at offset 0xb40.