Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment labels and redirections #22

Merged
merged 4 commits into from Apr 6, 2020
Merged

Segment labels and redirections #22

merged 4 commits into from Apr 6, 2020

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 2, 2019

I recommend to not add a segment to only create a HTTPS redirection.

The segments are mainly made to manage multiple ports on one container.

I created this PR because some our users follow this guide and create segments even if it's not needed.

@ldez
Copy link
Contributor Author

ldez commented Sep 3, 2019

ping @tiangolo 😉

luizjr
luizjr approved these changes Mar 25, 2020
luizjr
luizjr approved these changes Mar 25, 2020
@tiangolo tiangolo merged commit 09a543c into tiangolo:master Apr 6, 2020
5 checks passed
@tiangolo
Copy link
Owner

tiangolo commented Apr 6, 2020

Thanks for your contribution and for taking the time to do this @ldez ! 🙇‍♂️ 🚀 🎉

And thanks for the patience 😅 🤓

@luizjr
Copy link
Contributor

luizjr commented Apr 6, 2020

Hello @tiangolo, are you going to do the other merges?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants