New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for docs/ja/docs/advanced/websockets.md
#4983
🌐 Add Japanese translation for docs/ja/docs/advanced/websockets.md
#4983
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage
Additional details and impacted files@@ Coverage Diff @@
## master #4983 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13672 -297
==========================================
- Hits 13969 13672 -297
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate for your contribution!!!
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/ja/docs/advanced/websockets.md
docs/ja/docs/advanced/websockets.md
docs/ja/docs/advanced/websockets.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
🌐 Add Japanese translation for install section of websocket Co-authored-by: komtaki <39375566+komtaki@users.noreply.github.com>
レビューありがとうございます。Suggestedしていただいた通りにインストール手順の追加とコンフリクトの修正を行いました。 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!!
LGTM
Relates to #1572
This PR translates advanced/websockets.md.
I am Japanese and I like this repository so I translated it.
This is my first pull request for fastapi, so I apologize if there are any problems. I would appreciate it if you could check it.