Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Add Japanese translation for docs/ja/docs/advanced/websockets.md #4983

Merged

Conversation

xryuseix
Copy link
Contributor

@xryuseix xryuseix commented Jun 3, 2022

Relates to #1572

This PR translates advanced/websockets.md.

I am Japanese and I like this repository so I translated it.
This is my first pull request for fastapi, so I apologize if there are any problems. I would appreciate it if you could check it.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 馃憤

Coverage data is based on head (ee4e6a1) compared to base (cf73051).
Patch has no changes to coverable lines.

Current head ee4e6a1 differs from pull request most recent head 2ace4d0. Consider uploading reports for the commit 2ace4d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #4983    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13672   -297     
==========================================
- Hits         13969     13672   -297     
Impacted Files Coverage 螖
tests/main.py 100.00% <0.00%> (酶)
tests/utils.py 100.00% <0.00%> (酶)
fastapi/utils.py 100.00% <0.00%> (酶)
fastapi/routing.py 100.00% <0.00%> (酶)
fastapi/encoders.py 100.00% <0.00%> (酶)
tests/test_query.py 100.00% <0.00%> (酶)
fastapi/websockets.py 100.00% <0.00%> (酶)
fastapi/concurrency.py 100.00% <0.00%> (酶)
fastapi/applications.py 100.00% <0.00%> (酶)
fastapi/openapi/docs.py 100.00% <0.00%> (酶)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
馃摙 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

馃摑 Docs preview for commit 31ea851 at: https://629a33ffacfdc31daf3b4e19--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate for your contribution!!!

docs/ja/docs/advanced/websockets.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/websockets.md Outdated Show resolved Hide resolved
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

馃摑 Docs preview for commit a88f26b at: https://62aba7cf9c45893f00620a58--fastapi.netlify.app

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit ee4e6a1 at: https://62aba909520be73ebdb408ef--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title 馃寪 Add Japanese translation for - docs/ja/docs/advanced/websockets.md 馃寪 Add Japanese translation for - docs/ja/docs/advanced/websockets.md Jul 14, 2022
@tiangolo tiangolo changed the title 馃寪 Add Japanese translation for - docs/ja/docs/advanced/websockets.md 馃寪 Add Japanese translation for docs/ja/docs/advanced/websockets.md Jul 14, 2022
@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting review labels Jul 14, 2022
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. 馃憤

docs/ja/docs/advanced/websockets.md Show resolved Hide resolved
docs/ja/docs/advanced/websockets.md Outdated Show resolved Hide resolved
xryuseix and others added 2 commits November 7, 2022 16:53
馃寪 Add Japanese translation for install section of websocket

Co-authored-by: komtaki <39375566+komtaki@users.noreply.github.com>
@xryuseix
Copy link
Contributor Author

xryuseix commented Nov 7, 2022

銉儞銉ャ兗銇傘倞銇屻仺銇嗐仈銇栥亜銇俱仚銆係uggested銇椼仸銇勩仧銇犮亜銇熼氥倞銇偆銉炽偣銉堛兗銉墜闋嗐伄杩藉姞銇ㄣ偝銉炽儠銉偗銉堛伄淇銈掕銇勩伨銇椼仧銆
Thanks for the review, we have added an install section and fixed the conflicts.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

馃摑 Docs preview for commit 2ace4d0 at: https://6368bb6939a24014a9ea7aaa--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 9, 2022
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!! 馃憦

LGTM 馃殌

@tiangolo
Copy link
Owner

Great, thanks @xryuseix! 馃殌

And thanks for the reviews @komtaki and @tokusumi 馃嵃

@tiangolo tiangolo merged commit 59208e4 into tiangolo:master Nov 13, 2022
9 checks passed
@xryuseix xryuseix deleted the add-ja-translate-advanced-websockets branch November 13, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants