Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Clarify docs on CORS #5627

Merged
merged 1 commit into from Nov 13, 2022
Merged

✏️ Clarify docs on CORS #5627

merged 1 commit into from Nov 13, 2022

Conversation

paxcodes
Copy link
Contributor

Based on Issue #1090, I propose a change to the docs to:

The Accept, Accept-Language, Content-Language and Content-Type headers are always allowed for CORS requests.
The Accept, Accept-Language, Content-Language and Content-Type headers are always allowed for simple CORS requests.

@github-actions
Copy link
Contributor

📝 Docs preview for commit d801312 at: https://63704f0413b9ce57cf82080f--fastapi.netlify.app

iudeen
iudeen approved these changes Nov 13, 2022
Copy link
Contributor

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This seems to clarify

@tiangolo tiangolo changed the title ✏️ Clarify docs on cors ✏️ Clarify docs on CORS Nov 13, 2022
@tiangolo tiangolo merged commit fc717f8 into tiangolo:master Nov 13, 2022
9 checks passed
@tiangolo
Copy link
Owner

Awesome, thanks @paxcodes ! 🍰

And thanks for the help @iudeen 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants