Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: GetContainingModules() can alter path case #204

Closed
makubacki opened this issue Nov 10, 2022 · 0 comments · Fixed by #205
Closed

[Bug]: GetContainingModules() can alter path case #204

makubacki opened this issue Nov 10, 2022 · 0 comments · Fixed by #205
Assignees
@makubacki
Labels
bug Something isn't working
Milestone
0.12.1

Comments

@makubacki
Copy link
Member

Contact Details

No response

Describe the Bug

GetContainingModules() converts paths to lower case for internal path comparison. One of those path conversions can be returned externally preventing the absolute path string return value from matching the exact path case value.

Reproduction steps

  1. Pass an absolute path to Edk2Path.GetContainingModules()
  2. Verify case on return

Expected behavior

The exact case passed to the function should be returned.

Execution Environment

No response

Pip packages

No response

Additional context

I've written a test case to show the issue and confirm the fix that will be checked in with the change.
@makubacki makubacki added the bug Something isn't working label Nov 10, 2022
makubacki added a commit to makubacki/edk2-pytool-library that referenced this issue Nov 10, 2022
@makubacki
path_utilities.py: Prevent path case modification in GetContainingMod…
c6f7552 
…ules()

Closes tianocore#204

Updates `Edk2Path.GetContainingModules()` to preserve case the case
for each absolute path returned in the list of absolute paths.

This allows callers dependent on case comparison to get the expected
result.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki mentioned this issue Nov 10, 2022
Merged
makubacki added a commit to makubacki/edk2-pytool-library that referenced this issue Nov 10, 2022
@makubacki
path_utilities.py: Prevent path case modification in GetContainingMod…
e920a29 
…ules()

Closes tianocore#204

Updates `Edk2Path.GetContainingModules()` to preserve case the case
for each absolute path returned in the list of absolute paths.

This allows callers dependent on case comparison to get the expected
result.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@Javagedes Javagedes added this to the 0.12.1 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makubacki makubacki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.12.1
2 participants
@makubacki @Javagedes