Skip to content

Commit

Permalink
OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipi
Browse files Browse the repository at this point in the history
PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when the
full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is true
by default, but needs to be disabled for QEMU/OVMF where early INIT is
not simulated. Commit 1d76560 ("OvmfPkg: Disable
PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it by default
for OvmfPkg, but a similar change was not made for the AmdSev package.
This breaks booting of SEV and SNP guests.

Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev
package, as was previously done for OvmfPkg variants.

Fixes: eaffa1d ("UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.")
Signed-off-by: Michael Roth <michael.roth@amd.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
mdroth authored and mergify[bot] committed Sep 5, 2023
1 parent dfb941d commit 8b66f9d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions OvmfPkg/AmdSev/AmdSevX64.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,14 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|TRUE
gUefiOvmfPkgTokenSpaceGuid.PcdBootRestrictToFirmware|TRUE

#
# INIT is now triggered before BIOS by ucode/hardware. In the OVMF
# environment, QEMU lacks a simulation for the INIT process.
# To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to
# broadcast INIT-SIPI-SIPI for the first time.
#
gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE

################################################################################
#
# Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Platform
Expand Down

0 comments on commit 8b66f9d

Please sign in to comment.