Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pytools/Plugin/LicenseCheck: Use temp directory for git diff output #2217

Merged

Conversation

mdkinney
Copy link
Member

@mdkinney mdkinney commented Nov 23, 2021

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3746

Use --output option in git diff command to remove code diffs
from build log on stdout when LicenseCheck plugin is run.
Instead, create a temp directory for the diff output file and
remove the temp directory after the diff output is processed.

Cc: Sean Brogan sean.brogan@microsoft.com
Cc: Bret Barkelew Bret.Barkelew@microsoft.com
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Michael Kubacki michael.kubacki@microsoft.com
Signed-off-by: Michael D Kinney michael.d.kinney@intel.com

@mdkinney mdkinney force-pushed the Bug_3746_LicenseCheckUseDiffOutputFile_V2 branch from 42b2090 to d5a1b7f Compare Nov 26, 2021
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3746

Use --output option in git diff command to remove code diffs
from build log on stdout when LicenseCheck plugin is run.
Instead, create a temp directory for the diff output file and
remove the temp directory after the diff output is processed.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
@mdkinney mdkinney force-pushed the Bug_3746_LicenseCheckUseDiffOutputFile_V2 branch from d5a1b7f to 0ed51c1 Compare Nov 29, 2021
@mdkinney mdkinney added the push label Nov 29, 2021
@mergify mergify bot merged commit 99f84ff into tianocore:master Nov 29, 2021
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push
Projects
None yet
1 participant