Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone3 syscall #13

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Fix clone3 syscall #13

merged 3 commits into from
Sep 14, 2021

Conversation

lucaskanashiro
Copy link
Collaborator

For more info: https://bugs.launchpad.net/cloud-images/+bug/1943049

autopkgtest is still happy:

autopkgtest [11:35:16]: @@@@@@@@@@@@@@@@@@@@ summary
basic-smoke          PASS
docker-in-lxd        PASS

@mwhudson
Copy link
Collaborator

This LGTM. How much work do you think it would be to implement a dep8 test that deboostrapped the devel series and did some minimal tests of that? Or something in that vein? I guess dep8 testing the devel series in an LTS backport is a bit odd as it can be broken by changes outside of what the test runner thinks is being tested but otoh it would be really good to know about this sort of thing sooner...

(This doesn't have to be done before we merge this, it would just be a good thing to have)

@lucaskanashiro
Copy link
Collaborator Author

I updated my branch with the latest changes @tianon made to his upstream PR. Could @mwhudson or @tianon give me a +1 on this?

@lucaskanashiro
Copy link
Collaborator Author

This LGTM. How much work do you think it would be to implement a dep8 test that deboostrapped the devel series and did some minimal tests of that? Or something in that vein? I guess dep8 testing the devel series in an LTS backport is a bit odd as it can be broken by changes outside of what the test runner thinks is being tested but otoh it would be really good to know about this sort of thing sooner...

I believe we should definitely have a dep8 test like that. In order to avoid the problem you mentioned when backporting it to LTS releases, we could check in the test if it's running in a development release, if not we return the 77 exit code and mark the test as skippable, with this it would be skipped in non-development releases.

(This doesn't have to be done before we merge this, it would just be a good thing to have)

Agreed. We can release this change now, and then work on this dep8 test in a separate branch.

Copy link
Owner

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucaskanashiro lucaskanashiro merged commit 0f9cda4 into ubuntu Sep 14, 2021
@lucaskanashiro lucaskanashiro deleted the fix-clone3-syscall branch September 14, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants