Issue39 #40

Merged
merged 1 commit into from May 8, 2012

2 participants

@michalt

The patch fixes the issue for me. I've run the testsuite and everything seems to be ok. Not sure if you want to add a regression test, so I've made it a separate commit.

What do you think about it?

@michalt

Ugh.. The patch has a small bug itself. I'll push a fix in a minute.. Sorry for that.

@michalt

I've added a small optimization using the fact that Array.length is O(1).

Anyway, sorry for so many commits -- I guess I'm just a bit tired..

@tibbe
Owner

Thanks for the patches! Do you mind addressing the two comments I made on one of the commits and then rebase the result into one (or two if you want to separate out the test) commits on top of master?

@michalt

Thanks for a quick review! I've deleted the unnecessary comparisons and squashed everything into one commit.

@tibbe tibbe merged commit 6129d50 into tibbe:master May 8, 2012
@tibbe
Owner

Merged. Thanks for the patch! Do you need a release with this bug fix soon?

@michalt

Thanks! And no, the bug is not a blocker for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment